Skip to content

Capella cleanup #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2023
Merged

Capella cleanup #3845

merged 2 commits into from
Jan 6, 2023

Conversation

realbigsean
Copy link
Member

Issue Addressed

Proposed Changes

  • remove unused methods
  • fix potential panic in type conversion
  • error handling in default_at_fork
  • remove web3signer blobs code
  • remove post blobs from bn api client
  • log instead of panic in p2p
  • fix lcli payload decoding

Additional Info

@realbigsean realbigsean added ready-for-review The code is ready for review capella labels Dec 30, 2022
realbigsean
realbigsean commented Jan 3, 2023
View reviewed changes
@ethDreamer
Copy link
Member

LGTM!

@ethDreamer ethDreamer merged commit 6b72f45 into sigp:capella Jan 6, 2023
@realbigsean realbigsean deleted the capella-cleanup branch November 21, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
capella ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realbigsean @ethDreamer