[Merged by Bors] - Add disable-log-timestamp flag (#3101) #3586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Issues Addressed Closes sigp#3101 ## Proposed Changes Add global flag to suppress timestamps in the terminal logger.
michaelsproul
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Awesome, thanks!
Happy to merge this once the dust for v3.1.1 has settled. I'll mark it as blocked until then.
I've also opened a related issue about testing flags like this, but no pressure to take that on: #3588
|
We decided not to release v3.1.1 due to a bug (cf. #3600), so I'm unblocking this for inclusion in v3.1.2 |
|
bors r+ |
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Addressed
Closes #3101
Proposed Changes
Add global flag to suppress timestamps in the terminal logger.