-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
load CAPTCHA to enable phone number verification #5121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Running on windows 10, it looks like the captcha window opens a white screen for me. Navigating to https://signalcaptchas.org/registration/generate.html shows a Recaptcha 3 box. However I don't see the Recaptcha 3 UI in the captcha window. |
@josephdangerstewart you need to set the
|
Oh whoops, looks like I missed that part in the contributing guidelines 😅 Thanks for pointing it out! |
I have cherry-picked your changes onto the latest version of master. When I tried out on my Mac, I have infinite captcha check with no SMS received 😅 |
@elisedjn Did you remember to regenerate the assets before starting the app (by running |
@kevinsung Sorry for my late answer. |
Hello, This is the Log: So i tried checking out kevinsung/captcha with which i then run
Any Help Appreciated |
@RagonEbker It's likely that this branch doesn't work anymore because I've let it fall so far behind the development branch. For now, I don't intend to update this PR unless the Signal developers express interest in reviewing it. If someone else would like to fix the conflicts and open a new PR to replace mine, I will gladly close this one. |
I've created a draft PR at #5473 to resolve the merge conflicts in this PR. As this is my first contribution, constructive feedback is warmly welcomed before I submit this PR for merge. |
First time contributor checklist:
Contributor checklist:
development
branchyarn ready
run passes successfully (more about tests here)Description
Fixes #5006.
Loads the CAPTCHA that is required for verification to register a phone number with the desktop app as a standalone device for development. I adapted this from Signal-Android. When a request for SMS or voice verification is rejected with error code 402, a new window with a CAPTCHA appears, and upon successful completion of the CAPTCHA, the window closes and the request is sent again with the newly acquired credentials.
This requires the SIGNAL_ENABLE_HTTP environment variable to be set, e.g. on Linux,
I tested manually that this works and that it allowed me to successfully register a phone number. I tested this on Arch Linux (kernel version 5.11.8-arch1-1).
Screenshots:

