-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
load CAPTCHA to enable phone number verification #5473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load CAPTCHA to enable phone number verification #5473
Conversation
413829c
to
2cb38e7
Compare
2cb38e7
to
bc5691a
Compare
Is the patch still working? I tested with the latest Git version on Ubuntu 20.04.3 LTS (Lubuntu version) but when selecting "Set Up as Standalone Device", entering my French phone number and clicking the button "Send SMS", a new window "CAPTCHA Response Required" is opened but it is blank. I followed the build instructions from https://github.com/signalapp/Signal-Desktop/blob/development/CONTRIBUTING.md and in the Linux console, I can see the error Update: I forgot to type |
@sockbot, this PR has gone stale, but I updated it to work again on my fork at dsanders11/Signal-Desktop@0b59689. It doesn't automatically refresh after successfully verifying, requires closing and start the app again, but it does work to set up the device. Feel free to use that commit to update this PR so it's no longer stale. |
@dsanders11 I tested your fork but the app does not load even after restarting it, it keeps saying "Loading..." with the loading animation. In the web console, I noticed an error message: "HTTPError: promiseAjax: error response; code: 401". Do you have a solution? |
@baptx closing and reopening should do it. But this that code may have gone stale since it was last tested. |
Hello! Could you give a try to standalone registration in the latest beta? I think it might be working! |
@indutny-signal Hello, I tried v5.27.0-beta.2 by following the install instructions from https://github.com/signalapp/Signal-Desktop/blob/v5.27.0-beta.2/CONTRIBUTING.md which uses the command |
@indutny-signal I am using Linux and tried your link, the previous issue does not happen anymore but I cannot see "Setup as Standalone Device" in the File menu, there is only "Set Up as New Device" which does not change anything. |
Oh right... It works only in |
@indutny-signal thanks for sharing the instructions to use the production servers, good to know! But to fix the loading issue, I just had to remove the To set up the standalone device, I had to use the fork of @dsanders11 which works, I was able to complete the CAPTCHA and send / receive messages between 2 phone numbers (tested by replacing the Is there no way to enable the development mode (or at least set up a standalone device) in the official desktop version? In the future, it would be nice to be able to set up a standalone device without having to build the app in development mode, which could be useful for people without IT knowledge that don't have an Android or iOS smartphone. It would also be good to be able to use Signal without phone number because currently if someone loses their phone / it gets stolen or they change the phone number, it could be an issue to continue a conversation. A web version like WhatsApp and Telegram would be welcome also, so we can use Signal without installing an app and even if there is no app for our device. |
First time contributor checklist:
Contributor checklist:
development
branchyarn ready
run passes successfully (more about tests here)Description
This PR fixes merge conflicts in @kevinsung 's fix for #5006 at #5121. I tested manually that this works and that it allowed me to successfully register a phone number. I tested this on MacOS 10.15.7.
Kevin's PR notes:
Loads the CAPTCHA that is required for verification to register a phone number with the desktop app as a standalone device for development. I adapted this from Signal-Android. When a request for SMS or voice verification is rejected with error code 402, a new window with a CAPTCHA appears, and upon successful completion of the CAPTCHA, the window closes and the request is sent again with the newly acquired credentials.
This requires the SIGNAL_ENABLE_HTTP environment variable to be set, e.g. on Linux,
SIGNAL_ENABLE_HTTP=1 yarn start
I tested manually that this works and that it allowed me to successfully register a phone number. I tested this on Arch Linux (kernel version 5.11.8-arch1-1).
Screenshots