process: Fix parsing of uid/gid's to handle full uint32 range #1887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following can be seen when doing a Process::Status():
strconv.ParseInt: parsing "2976972800": value out of range
We're treating the uid/gid fields as if they're int32's when parsing,
but they're uint32's. A large enough uid/gid can kick us over the edge.
Handle it as a uint32 and add a test around it.
This is similar to what
aace5e9 ("Groups in /proc/PID/status has type uint32.") did for Groups.
Signed-off-by: Andrew Halaney <ahalaney@netflix.com>
shirou
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following can be seen when doing a Process::Status():
We're treating the uid/gid fields as if they're int32's when parsing, but they're uint32's. A large enough uid/gid can kick us over the edge.
Handle it as a uint32 and add a test around it.
This is similar to what
aace5e9 ("Groups in /proc/PID/status has type uint32.") did for Groups.