Sorry for the delayed review.

I’m in favor of adding linting for shadowing. However, after reading this PR twice, I still feel that applying it to err might be overkill.

For example, take the following code:

if err := common.Sleep(ctx, interval); err != nil {

Changing it to:

err := common.Sleep(ctx, interval)
if err != nil {

feels a bit much.

The former is a common idiom in Go and makes it clear that we're only dealing with the err returned by common.Sleep, which seems preferable.

Since err is such a commonly used variable name in Go, I feel like some amount of shadowing is unavoidable. Is there a way to configure the linter to ignore shadowing specifically for err?

I'm wondering if using this form will work

if err := common.Sleep(ctx, interval); err != nil {

Let's give this a try

It works. The issue comes often from the very first err that is define in the scope, that implies everything else will be reported as shadowed.

The solution is to use the if err := whatever(); err != nil { everywhere

Since err is such a commonly used variable name in Go, I feel like some amount of shadowing is unavoidable. Is there a way to configure the linter to ignore shadowing specifically for err?

The solution is described here

• Add default exclude for shadowing of err/ctx golangci/golangci-lint#166 (comment)