Skip to content

fix ignore nakedret #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2025
Merged

fix ignore nakedret #1847

merged 1 commit into from
May 11, 2025

Conversation

mmorel-35
Copy link
Contributor

Description

remove //nolint:nakedret //FIXME comments and fix issues

@mmorel-35 mmorel-35 force-pushed the nakedret branch 3 times, most recently from 87ce0cd to d631a70 Compare May 9, 2025 06:40
@mmorel-35
fix ignore nakedret
6a79b39 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
shirou
shirou approved these changes May 11, 2025
View reviewed changes
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you so much!

@shirou shirou merged commit 3ef5d4c into shirou:master May 11, 2025
52 checks passed
@mmorel-35 mmorel-35 deleted the nakedret branch May 11, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirou shirou shirou approved these changes

+1 more reviewer

@ccoVeille ccoVeille ccoVeille approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
package:cpu package:host package:net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @shirou @ccoVeille