[host]: fix potential error on CI test on Windows. #1830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a potential synchronization issue during the execution of the CI test on Windows.
- Replaced a direct call to wg.Done() with a deferred call to ensure proper execution even in the presence of early exits due to errors.
Comments suppressed due to low confidence (1)
host/host_test.go:118
- Using 'defer wg.Done()' ensures that the wait group counter is decremented even if the test is skipped or an error occurs, which prevents potential deadlocks during concurrent test execution.
defer wg.Done()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the test
host/TestVirtualizationon CI fails. This PR try to fix the error even if I can not reproduce the error.