Skip to content

feat(process_windows): Support collecting PageFault count in Windows #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 7, 2025
Merged

feat(process_windows): Support collecting PageFault count in Windows #1769

merged 5 commits into from
Mar 7, 2025

Conversation

zmyzheng
Copy link
Contributor

This PR adds the statistics collection for PageFault count in Windows. Different from Linux which specifies Major Page Fault and Minor Page Fault, Windows only provides the total PageFault count.

@shirou shirou mentioned this pull request Jan 3, 2025
Closed
@shirou
Copy link
Owner

shirou commented Mar 6, 2025

Sorry for keeping you waiting. After conducting a survey, it appears that all operating systems except Windows distinguish between Major and Minor faults. I believe adding "Total" solely for Windows might lead to inconsistency.

Therefore, how about adding mem.PageFaultCount to "Major" and including a comment like, "Since Windows does not distinguish between Major and Minor faults, all faults are treated as Major"?

@zmyzheng
Copy link
Contributor Author

zmyzheng commented Mar 6, 2025

Sorry for keeping you waiting. After conducting a survey, it appears that all operating systems except Windows distinguish between Major and Minor faults. I believe adding "Total" solely for Windows might lead to inconsistency.

Therefore, how about adding mem.PageFaultCount to "Major" and including a comment like, "Since Windows does not distinguish between Major and Minor faults, all faults are treated as Major"?

Sounds good. Thanks @shirou for the investigation. I updated the code based on your suggestion.

shirou
shirou approved these changes Mar 7, 2025
View reviewed changes
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@shirou shirou merged commit 6039e8f into shirou:master Mar 7, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirou shirou shirou approved these changes

Assignees
No one assigned
Labels
package:process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmyzheng @shirou