move debian packaging out to dedicated step #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current package detailsCurrent package file listClick to expand! |
New package detailsNew package file listClick to expand! |
Closed
shiftkey
commented
Apr 23, 2020
| @@ -172,5 +172,8 @@ | |||
| "electron-builder": "22.4.1", | |||
| "electron-packager": "^14.2.1", | |||
| "electron-winstaller": "4.0.0" | |||
| }, | |||
| "optionalDependencies": { | |||
There was a problem hiding this comment.
I had to use this section because Windows will complain that it cannot install this.
Minor thing to be aware of if this ever gets upstreamed.
| maintainer: 'Brendan Forster <github@brendanforster.com>', | ||
| } | ||
|
|
||
| export async function packageDebian(): Promise<string> { |
There was a problem hiding this comment.
This is the pattern I stumbled upon for these modules - an exported function that does the work to perform the packaging, returning a string when the promise resolves, or throwing an error if it cannot complete.
This felt a bit cleaner than using sync functions from Node to perform blocking work, and there's examples in here where we can convert a callback-based function into a promise-returning function using util.promisify.
| return Promise.reject('Windows is not supported') | ||
| } | ||
|
|
||
| const installer = require('electron-installer-debian') |
There was a problem hiding this comment.
This is required inline because of the problem with the dependency not being present on Windows - easier to avoid this blowing up if the script is accidentally invoked.
| '1024x1024': 'app/static/logos/1024x1024.png', | ||
| }, | ||
| scripts: { | ||
| postinst: 'script/resources/deb/postinst.sh', |
There was a problem hiding this comment.
I've moved the original linux-after-install.sh and linux-after-remove.sh scripts into this directory to indicate it's tied to a specific installer, and as we find ourselves maintaining specific files for different installers we can introduce additional directories.
shiftkey
added a commit
that referenced
this pull request
Aug 17, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 17, 2024
shiftkey
added a commit
that referenced
this pull request
Sep 2, 2024
shiftkey
added a commit
that referenced
this pull request
Oct 30, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 8, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 8, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 8, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 8, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2024
shiftkey
added a commit
that referenced
this pull request
Feb 5, 2025
shiftkey
added a commit
that referenced
this pull request
Feb 5, 2025
shiftkey
added a commit
that referenced
this pull request
Feb 5, 2025
shiftkey
added a commit
that referenced
this pull request
Feb 5, 2025
shiftkey
added a commit
that referenced
this pull request
Feb 5, 2025
shiftkey
added a commit
that referenced
this pull request
Feb 9, 2025
shiftkey
added a commit
that referenced
this pull request
Feb 9, 2025
shiftkey
added a commit
that referenced
this pull request
Feb 9, 2025
shiftkey
added a commit
that referenced
this pull request
Feb 9, 2025
shiftkey
added a commit
that referenced
this pull request
Feb 9, 2025
shiftkey
added a commit
that referenced
this pull request
Mar 2, 2025
shiftkey
added a commit
that referenced
this pull request
Mar 2, 2025
shiftkey
added a commit
that referenced
this pull request
Mar 2, 2025
theofficialgman
pushed a commit
to theofficialgman/desktop
that referenced
this pull request
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #262
electron-installer-debianoptional for Windowsdpkg-debSectionandPriorityconfig valuesdependsset works and app launchesgithubcommand line shortcut worksmimeTypesstill work as expected