Skip to content

set filemode for chrome-sandbox executable during package #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

set filemode for chrome-sandbox executable during package #254

merged 1 commit into from
Apr 16, 2020

Conversation

shiftkey
Copy link
Owner

@shiftkey shiftkey commented Apr 14, 2020 •
edited
Loading

A partial fix for #222, but as we've uncovered in that issue the full fix requires:

  • sudo sysctl kernel.unprivileged_userns_clone=1 to enable unprivileged user namespaces (specifically disabled in Debian and other distros), or
  • passing --no-sandbox when launching the app (which effectively disables some of Chromium's security features)

This change will be applied for both deb and rpm packages, but I think it's low risk. Will verify in a test at some stage.

  • test RPM on Fedora and confirm defaults work as expected

@shiftkey shiftkey mentioned this pull request Apr 14, 2020
Closed
@jfgordon2
Copy link

If you want to compare your solution to electron's builder, check out updateSandboxHelperPermissions

@shiftkey shiftkey force-pushed the set-file-mode-for-sandbox branch from 7e361de to 8fbd606 Compare April 16, 2020 15:16
@shiftkey
Copy link
Owner Author

If you want to compare your solution to electron's builder, check out updateSandboxHelperPermissions

@jfgordon2 yep, that's the one I used for inspiration for this change

@shiftkey shiftkey marked this pull request as ready for review April 16, 2020 16:42
@shiftkey
Copy link
Owner Author

Looks like electron-builder was already setting this for the current RPM release, so I think this is good to merge.

@shiftkey shiftkey merged this pull request into linux Apr 16, 2020
@shiftkey shiftkey deleted the set-file-mode-for-sandbox branch April 16, 2020 16:45
shiftkey added a commit that referenced this pull request Apr 16, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
84ae87c 
…254)
shiftkey added a commit that referenced this pull request Apr 16, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
e545888 
…254)
shiftkey added a commit that referenced this pull request Apr 17, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
e301b51 
…254)
shiftkey added a commit that referenced this pull request Apr 23, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
d407abc 
…254)
shiftkey added a commit that referenced this pull request Apr 29, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
b9e3cbe 
…254)
shiftkey added a commit that referenced this pull request May 1, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
002aa46 
…254)
shiftkey added a commit that referenced this pull request May 1, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
a88c438 
…254)
shiftkey added a commit that referenced this pull request May 2, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
fbaf801 
…254)
shiftkey added a commit that referenced this pull request May 12, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
3934d04 
…254)
shiftkey added a commit that referenced this pull request May 12, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
825ed62 
…254)
shiftkey added a commit that referenced this pull request May 12, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
e2f393a 
…254)
shiftkey added a commit that referenced this pull request May 16, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
5ccae84 
…254)
shiftkey added a commit that referenced this pull request May 18, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
fd1f4a4 
…254)
shiftkey added a commit that referenced this pull request May 22, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
9745055 
…254)
shiftkey added a commit that referenced this pull request May 29, 2020
@shiftkey
set filemode for chrome-sandbox to reflect the permissions it needs (#…
5966818 
…254)
shiftkey added a commit that referenced this pull request Aug 17, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
50382f3
shiftkey added a commit that referenced this pull request Aug 17, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
8c90a99
shiftkey added a commit that referenced this pull request Sep 2, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
e27922b
shiftkey added a commit that referenced this pull request Oct 30, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
22d193c
shiftkey added a commit that referenced this pull request Nov 8, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
fca9955
shiftkey added a commit that referenced this pull request Nov 8, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
2795c9b
shiftkey added a commit that referenced this pull request Nov 8, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
3dcbdcc
shiftkey added a commit that referenced this pull request Nov 8, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
432bbf0
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
78f3b27
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
b4b2b25
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
270cb2a
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
8dfa896
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
786e936
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
f0953d5
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
890728b
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
1aea52a
shiftkey added a commit that referenced this pull request Feb 5, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
7fb5d5a
shiftkey added a commit that referenced this pull request Feb 5, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
de5bfae
shiftkey added a commit that referenced this pull request Feb 5, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
6b1a4bc
shiftkey added a commit that referenced this pull request Feb 5, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
aa0e355
shiftkey added a commit that referenced this pull request Feb 5, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
de6feaa
shiftkey added a commit that referenced this pull request Feb 9, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
f1dbc4f
shiftkey added a commit that referenced this pull request Feb 9, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
a4224aa
shiftkey added a commit that referenced this pull request Feb 9, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
f99d999
shiftkey added a commit that referenced this pull request Feb 9, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
f25b432
shiftkey added a commit that referenced this pull request Feb 9, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
f79f51c
shiftkey added a commit that referenced this pull request Mar 2, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
6e13f5c
shiftkey added a commit that referenced this pull request Mar 2, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
8ebd3e7
shiftkey added a commit that referenced this pull request Mar 2, 2025
@shiftkey
feat(tooling): add electron-builder config to repository (#254 #496)
9d7df29
theofficialgman pushed a commit to theofficialgman/desktop that referenced this pull request Jul 18, 2025
@shiftkey @theofficialgman
feat(tooling): add electron-builder config to repository (shiftkey#254 …
8cc6d86 
…shiftkey#496)

Co-Authored-By: Brendan Forster <github@brendanforster.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shiftkey @jfgordon2