Use Shinken WebUI with the Alignak framework #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- timeperiods - downtimes and comments for hosts/services
|
Hi @mohierf I don't have as much time as I would like to review the code properly, so I just merge to test and if everything is fine after a few days your PR will be accepted. Thanks a lot. It looks like a lot of work and I really appreciate you wanted to use this webui with alignak :) |
mohierf
added a commit
to mohierf/mod-webui
that referenced
this pull request
Nov 13, 2018
* Very first version tested locally - looks like everything is ok * Some Regenerator fixes and improvements - timeperiods - downtimes and comments for hosts/services * Fix shinken-monitoring#621 - fix external commands for host/service check results * Fix WebUI modules loading * Fix service display_name property
mohierf
added a commit
to mohierf/mod-webui
that referenced
this pull request
Nov 19, 2018
* Very first version tested locally - looks like everything is ok * Some Regenerator fixes and improvements - timeperiods - downtimes and comments for hosts/services * Fix shinken-monitoring#621 - fix external commands for host/service check results * Fix WebUI modules loading * Fix service display_name property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very first version tested locally - looks like everything is ok
Some small fixes to make this module compatible with Alignak
Added a Regenerator class inside the module for Alignak rather than using the Shinken one.
PS: note that even with the Shinken version it woud be better to include the Regenerator into the Web UI module 😉