Problems not showing counted errors on Dashboard #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also contains a fix on the stats module, so it works based on shinken notifications via slack (any notification command that matches /notify-service-by-slack/ will be taken into account. |
|
Hi @jmleoni and @bmalynovytch I agree with your commits. But why did you merge them in one pull request? Anyway, I merge, thank you. I will keep you posted when this is released. |
|
I'm sorry @bmalynovytch but merging was a mistake. Not displaying SOFT problems is intentional. I will update the dashboard counter to exclude SOFT states. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a misleading information on the Dashboard indicating the number of "problems".
Clicking on the counter (or the Problems link
/problemsin the main menu) then redirects to a custom filter.This filter doesn't have the same amount of "problems" because of "soft" states being excluded.
This PR changes the behaviour of the problems link, to include "soft" states, in accordance with the Dashboard counter.