Add SHA256 and SHA512 htpasswd auth methods #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's stopping this PR from being merged? Is there anything I can do to unblock it? |
|
Hi @Xenopathic, Only because I didn't see it, I'm sorry. I'm merging it now to test on my setup. Thank you very much for this PR :) |
mohierf
pushed a commit
to mohierf/mod-webui
that referenced
this pull request
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current htpasswd authentication only supports DES crypt, MD5 and bcrypt (with
$2y$only, which is a little odd). This PR adds in all the other bcrypt variants including the most common$2b$one, along with SHA256 and SHA512.Tested with bcrypt
$2y$and$2b$, and SHA256.