fix sound toggle bug #591
Merged
fix sound toggle bug #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sound good to me. Thank you @ornoone ! |
|
@ornoone 2.7.0 is now published, with this patch. Thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version
Shinken 2.4.3 — Web User Interface 2.6.1,
page
all (bug in layout)
expected behavior
when i click on the toggle sound icon, it should enable the sound, and change the icon of the button to remove the .fa-ban
current behavior
clicking on the button do absolutly nothing.
fix
I found in shinken-layout.js that the block that manage the event on this button is surounded by a If which check if a outdated ID exists. i fix it by changing this query by id
#alert-audiowith a query by class.js-toggle-sound-alertwhich target the same item, and is uniq.