Less visually distracting spinners for flapping services #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I'm not sure to see how the spinner look out of place. Is it because of the color inversion? I agree that they catch too much attention for a not-so-important information. I will take a look at your PR. |
|
In chrome I have a slight rotation bug that I don't see in firefox, but OK, I agree with you it's a lot better. Thank you @Ace13 ! Sadly I just published 2.5.2, but I will release 2.5.3 soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is one heck of a nitpick, but the regular flapping spinners look so out of place compared to all the other service icons.
This replaces them with spinning cogs instead, which still retains the original purpose but does so in a way that makes them look appropriate compared to the rest of the icons.
For instance, compare the cog and the spinner in this picture;
