Skip to content

configurable graph number on problem page #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

torgiren
Copy link

Added custom variable _graph_num to service description
Now you can choose which graph do you prefer to be displayed in problem page (instead of graph[0]).
If you omit _graph_num, default value 0 will be used

Example of use:
check_cpu which return bunch of stats (such as user, irq, nice etc).
default behaviour showed me random value (softirq in my case), but I wanted to get user

@mohierf
Copy link
Contributor

mohierf commented Apr 19, 2016

Still some reflection about this feature ... there is probably a best solution to implement this. What do you think @maethor ?

@maethor
Copy link
Contributor

maethor commented May 29, 2017

I don't know. I think it is a pretty nice feature to have. Would be really confidential, but like _DETAILLEDESC, _IMPACT and _FIXACTIONS, it doesn't cost anything.

With that said:

  • First, I think the variable name could be more clear. "_MAIN_GRAPH_NUMBER", maybe?
  • What's bothering me is that service definitions, and moreover packs, should not depend on what graphite or php4nagios will do with the perfdata. So I don't think it would be a good idea to put this variable in a pack, for instance, because the result would varies depending on the installation.

What do you think @torgiren ?

@maethor
Copy link
Contributor

maethor commented Sep 11, 2017

I am currently working on a solution to display all the graphs in this popover. So I'm closing this PR. @torgiren please try the webui 2.6 when it's released. I think you will find what you are looking for.

@maethor maethor closed this Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants