Add multiple color stops for gradients #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sharkdp merged 2 commits into sharkdp:master from felipe-fg:gradient-multiple-stops

Oct 13, 2019

Contributor

felipe-fg commented Oct 13, 2019

Add support for color scales and gradients with multiple colors at different positions.

Closes #49.

sharkdp reviewed

View reviewed changes

src/cli/cli.rs Outdated Show resolved Hide resolved

sharkdp reviewed

View reviewed changes

src/cli/error.rs Outdated Show resolved Hide resolved

sharkdp reviewed

View reviewed changes

src/lib.rs Show resolved Hide resolved

sharkdp reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

sharkdp reviewed

View reviewed changes

src/lib.rs Show resolved Hide resolved

sharkdp reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

sharkdp reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

sharkdp reviewed

View reviewed changes

src/lib.rs Show resolved Hide resolved

sharkdp reviewed

View reviewed changes

src/lib.rs Show resolved Hide resolved

sharkdp requested changes

View reviewed changes

Owner

sharkdp left a comment

Thank you very much!

The code looks really great. I added a few inline comments above.


          Add multiple color stops for gradients

691def8

Contributor Author

felipe-fg commented Oct 13, 2019

I've just pushed a new (ammed) commit to fix those issues.

sharkdp approved these changes

View reviewed changes

Owner

sharkdp left a comment

Thank you very much for the updates!


          Bump min. required Rust version to 1.35

357561c

sharkdp merged commit 4ec6719 into sharkdp:master

felipe-fg deleted the gradient-multiple-stops branch

October 19, 2019 14:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet