Options for reading between two offsets #43
Conversation
|
Thank you very much for your contribution! I will take a closer look soon. |
| let mut f = File::open(filename)?; | ||
|
|
||
| // apply start offset | ||
| if start_offset > 0 { |
There was a problem hiding this comment.
Is there a reason that this is limited to files? I understand that Stdin doesn't implement Seek, but surely it'd be fairly easy to just ignore input from StdinLock by using BufRead's fill_buf and consume,
One defense I can see for this is that it's not immediately obvious (to me) how to make that robust. See discussion below about errors for my thoughts on this.
|
|
||
| // apply start offset | ||
| if start_offset > 0 { | ||
| f.seek(SeekFrom::Start(start_offset)) |
There was a problem hiding this comment.
So, question: is this really an error if, say, the file simply wasn't as big as the specified offset? I think that this is a good default behavior, but I'm not sure about the case where the file size simply doesn't match.
This applies to the stdin discussion above since it's entirely possible to detect if there are any remaining bytes in stdin.
|
Happy to review this once the questions by @ErichDonGubler are answered. |
|
Just pinging @Regentag to take a look at the comments made so far -- excited to get your stuff through, just wanted to have some discussion! :) |
|
Any update on this? I'd love to use this feature @Regentag |
new option `-s'
related issue : #16