Skip to content

lib/sizeof.h: Make sure STRLEN() only accepts string literals #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

lib/sizeof.h: Make sure STRLEN() only accepts string literals #1260

merged 1 commit into from
May 26, 2025

Conversation

alejandro-colomar
Copy link
Collaborator

@alejandro-colomar alejandro-colomar mentioned this pull request May 25, 2025
Closed
@alejandro-colomar alejandro-colomar marked this pull request as ready for review May 25, 2025 13:07
ikerexxe
ikerexxe reviewed May 26, 2025
View reviewed changes
Copy link
Collaborator

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly is the benefit of this change? I only see one instance of STRLEN in the code and it is very clear that it uses a string. I am not saying that there is no fortification in the code, only that its benefit seems low.

@alejandro-colomar
Copy link
Collaborator Author

alejandro-colomar commented May 26, 2025 •
edited
Loading

What exactly is the benefit of this change? I only see one instance of STRLEN in the code and it is very clear that it uses a string. I am not saying that there is no fortification in the code, only that its benefit seems low.

Yeah, the benefit is low. I also doubted if I should send this patch. On the other hand, it's trivial to do it. I don't mind too much, so whatever you prefer. We can drop it if you want.

hallyn
hallyn approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@hallyn hallyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, well, safety...

I'll approve, please feel free to either merge or close.

@alejandro-colomar alejandro-colomar merged commit 1594167 into shadow-maint:master May 26, 2025
10 checks passed
@alejandro-colomar alejandro-colomar deleted the slen branch May 26, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikerexxe ikerexxe ikerexxe left review comments

@hallyn hallyn hallyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alejandro-colomar @hallyn @ikerexxe