src/newusers.c: Move break to loop condition #1267
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
Oops, no, this is bogus. |
|
Ahhhh, now I see it. So we parse 7 fields indeed: nfields is 0,1,2,3,4,5,6, and when we parsed the 7th (nfields is 6) we break out early without advancing nfields, which is why it says 6. So the second bug is not valid. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick from #1265 (at v3b).
This is a refactor that will help see a bug (and its fix). It will also help transition to using STRSEP2ARR() in #1155