newuidmap: better error logging on failure #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da8a339 to
2a4c06e
Compare
|
The code changes look good, but there are two things to improve. Can you change the On top of that, can you add another commit fixing |
The handling for `sub_uid_open` relies on `commonio_open` preserving `errno`, which it appears to make an effort do, but doesn't explicitly document. Closes: shadow-maint#1253
Much like the previous commit, similarly relies on `sub_gid_open` preserving `errno`.
2a4c06e to
ba0daae
Compare
|
Thanks for the review
Done: 5cc516b
Done: ba0daae |
ikerexxe
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling for
sub_uid_openrelies oncommonio_openpreservingerrno, which it appears to make an effort do, but doesn't explicitly document.Closes: #1253