Skip to content

Conversation

ikerexxe
Copy link
Collaborator

This accelerates the CI.

Resolves: #1240
Link: https://101010.pl/@nabijaczleweli/114149412203886808
Reported-by: nabijaczleweli nabijaczleweli@nabijaczleweli.xyz

@ikerexxe
Copy link
Collaborator Author

ikerexxe commented Mar 20, 2025

@alejandro-colomar if I compare the build time for the actions that do any build from this PR:

To the ones from #1237:

It seems like there is a notorious improvement in the last two actions. WDYT?

Copy link
Collaborator

@alejandro-colomar alejandro-colomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

@alejandro-colomar
Copy link
Collaborator

alejandro-colomar commented Mar 20, 2025

This accelerates the CI.

Resolves: #1240 Link: https://101010.pl/@nabijaczleweli/114149412203886808 Reported-by: nabijaczleweli nabijaczleweli@nabijaczleweli.xyz

I think Closes: is more common than Resolves: in the projects I've seen.

Here's the Linux kernel:

alx@devuan:~/src/linux/linux/master$ git log --grep '^\(Resolves\|Closes\):' | grep -o '\(Resolves\|Closes\):' | head -n1000 | sort | uniq -c;
   1000 Closes:

Shadow:

alx@devuan:~/src/shadow/shadow/master$ git log --grep '^\(Resolves\|Closes\):' | grep -o '\(Resolves\|Closes\):' | head -n1000 | sort | uniq -c
     44 Closes:
     42 Resolves:

BTW, @nabijaczleweli usually signs as наб <nabijaczleweli@nabijaczleweli.xyz>, in Cyrillic.

This accelerates the CI.

Closes: shadow-maint#1240
Link: <https://101010.pl/@nabijaczleweli/114149412203886808>
Reported-by: наб <nabijaczleweli@nabijaczleweli.xyz>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Alejandro Colomar <alx@kernel.org>
@ikerexxe ikerexxe marked this pull request as ready for review March 20, 2025 11:00
@ikerexxe
Copy link
Collaborator Author

I think Closes: is more common than Resolves: in the projects I've seen.
BTW, @nabijaczleweli usually signs as наб <nabijaczleweli@nabijaczleweli.xyz>, in Cyrillic.

I updated those two and with your permission I have also added Reviewed-by: Alejandro Colomar <alx@kernel.org>

@alejandro-colomar
Copy link
Collaborator

Thanks! I'll merge.

@alejandro-colomar alejandro-colomar merged commit ab89ca4 into shadow-maint:master Mar 20, 2025
10 checks passed
@ikerexxe ikerexxe deleted the ci-purge-mandb branch March 21, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly faster CI
2 participants