Skip to content

Add LOGIN_ENV_SAFELIST to FOREIGNDEFS #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Add LOGIN_ENV_SAFELIST to FOREIGNDEFS #1248

merged 1 commit into from
Apr 9, 2025

Conversation

stanislav-brabec
Copy link
Contributor

util-linux-2.41 introduced new variable: LOGIN_ENV_SAFELIST. Add it to known login.defs variables.

@stanislav-brabec
Add LOGIN_ENV_SAFELIST to FOREIGNDEFS
d2cb7d5 
util-linux-2.41 introduced new variable: LOGIN_ENV_SAFELIST.
Add it to known login.defs variables.

Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
ikerexxe
ikerexxe approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making the effort to port this here.

@ikerexxe ikerexxe merged commit c4cc71f into shadow-maint:master Apr 9, 2025
10 checks passed
@stanislav-brabec
Copy link
Contributor Author

We have a tool for that in openSUSE. Would the upstream be interested? It is an ugly hack that parses precompiler output of shadow and sources of pam and util-linux:
https://build.opensuse.org/projects/Base:System/packages/shadow/files/shadow-login_defs-check.sh?expand=1

And additional patches:

Things that needs to be changed in login.defs to switch from shadow login to util-linux login:
https://build.opensuse.org/projects/Base:System/packages/shadow/files/shadow-util-linux.patch?expand=1

Things that cannot be used if pam tools are used in favor of shadow tools:
https://build.opensuse.org/projects/Base:System/packages/shadow/files/shadow-login_defs-unused-by-pam.patch?expand=1

Comments improvements (again, may depend on the binary selection between shadow, util-linux and pam):
https://build.opensuse.org/projects/Base:System/packages/shadow/files/shadow-login_defs-comments.patch?expand=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikerexxe ikerexxe ikerexxe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanislav-brabec @ikerexxe