passwd: document exit code when PAM has errored #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
approved these changes
Mar 22, 2025
There was a problem hiding this comment.
Except for the minor issues noted in the comment,
Reviewed-by: Alejandro Colomar <alx@kernel.org>
@Zugschlus is this enough for you? (I think the separation of error codes would be a separate thing.)
closes shadow-maint#1219 When pam returns an error, we were exiting with exit code 10, which was hardcoded and not documented. Create a name for it, and document it in the manpage. Signed-off-by: Serge Hallyn <serge@hallyn.com> Reported-by: Marc Haber <githubvisible@zugschlus.de> Reviewed-by: Alejandro Colomar <alx@kernel.org>
|
Thanks! I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1219
When pam returns an error, we were exiting with exit code 10, which was hardcoded and not documented. Create a name for it, and document it in the manpage.
Reported-by: Marc Haber githubvisible@zugschlus.de