Skip to content

lib/fs/mkstemp/, src/: Move fmkomstemp() to separate files under lib/fs/mkstemp/, and split into mkomstemp() #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

lib/fs/mkstemp/, src/: Move fmkomstemp() to separate files under lib/fs/mkstemp/, and split into mkomstemp() #1139

merged 2 commits into from
Jun 3, 2025

Conversation

alejandro-colomar
Copy link
Collaborator

@alejandro-colomar alejandro-colomar commented Dec 4, 2024 •
edited
Loading

This reduces the complexity of fmkomstemp() by adding a helper API, and moves this into the lib/fs/ library subdir.

Revisions:

v1b
  • Rebase
$ git range-diff master..gh/fmkomstemp shadow/master..fmkomstemp 
1:  257e2aaf = 1:  aa3d3676 lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  6b28ca78 = 2:  dae656e6 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v1c
  • Rebase
$ git range-diff master..gh/fmkomstemp shadow/master..fmkomstemp 
1:  aa3d3676 = 1:  3dfeb6fe lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  dae656e6 = 2:  f6224cb4 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v1d
  • Rebase
$ git range-diff master..gh/fmkomstemp shadow/master..fmkomstemp 
1:  3dfeb6fe = 1:  bf5be95a lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  f6224cb4 = 2:  3e913b68 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v1e
  • Rebase
$ git range-diff alx/master..gh/fmkomstemp master..fmkomstemp 
1:  bf5be95a = 1:  308ade0d lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  3e913b68 = 2:  3cf55a27 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v1f
  • Rebase
$ git range-diff alx/master..gh/fmkomstemp master..fmkomstemp 
1:  308ade0d = 1:  378b49e8 lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  3cf55a27 = 2:  b9f41b81 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v1g
  • Rebase
$ git range-diff master..gh/fmkomstemp shadow/master..fmkomstemp 
1:  378b49e8 = 1:  8973991d lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  b9f41b81 = 2:  e3c7ea4b lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v1h
  • Rebase
$ git range-diff master..gh/fmkomstemp shadow/master..fmkomstemp 
1:  8973991d = 1:  4733b6e3 lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  e3c7ea4b = 2:  721cddca lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v1i
  • Rebase
$ git range-diff master..gh/fmkomstemp shadow/master..fmkomstemp 
1:  4733b6e3 = 1:  7a8cd14a lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  721cddca = 2:  3926d6f4 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v2
  • Add comment spelling out the meaning of the letter soup. [@hallyn]
$ git range-diff shadow/master gh/fmkomstemp fmkomstemp 
1:  7a8cd14a = 1:  7a8cd14a lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  3926d6f4 ! 2:  e1199b27 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
    @@ lib/fs/mkstemp/fmkomstemp.h
      
      inline FILE *fmkomstemp(char *template, unsigned int flags, mode_t m);
      
    -@@ lib/fs/mkstemp/fmkomstemp.h: fmkomstemp(char *template, unsigned int flags, mode_t m)
    + 
    ++// FILE make with-open(2)-flags with-mode secure temporary
    + inline FILE *
    + fmkomstemp(char *template, unsigned int flags, mode_t m)
    + {
        int   fd;
        FILE  *fp;
      
    @@ lib/fs/mkstemp/mkomstemp.h (new)
     +inline int mkomstemp(char *template, unsigned int flags, mode_t m);
     +
     +
    ++// make with-open(2)-like-flags with-mode secure temporary
     +inline int
     +mkomstemp(char *template, unsigned int flags, mode_t m)
     +{
v2b
  • Rebase
$ git range-diff master..gh/fmkomstemp shadow/master..fmkomstemp 
1:  7a8cd14a = 1:  58008553 lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  e1199b27 = 2:  84ce3120 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v2c
  • Rebase
$ git range-diff master..gh/fmkomstemp shadow/master..fmkomstemp 
1:  58008553 = 1:  dec8d42e lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  84ce3120 = 2:  c76299c7 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v2d
  • Rebase
$ git range-diff master..gh/fmkomstemp shadow/master..fmkomstemp 
1:  dec8d42e = 1:  f3a5aac8 lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  c76299c7 = 2:  83730e1d lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v2e
  • Rebase
$ git rd
1:  f3a5aac8 = 1:  349e1001 lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  83730e1d = 2:  02d0598d lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v2f
  • Rebase
$ git rd 
1:  349e1001 = 1:  9276ff79 lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  02d0598d = 2:  bec3ce53 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v2g
  • Rebase
$ git rd
1:  9276ff79 = 1:  88a92efc lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  bec3ce53 = 2:  501962ff lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v2h
  • Rebase
$ git rd
1:  88a92efc = 1:  b1db3ab5 lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  501962ff = 2:  6fafe78d lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v2i
  • Rebase
$ git rd
1:  b1db3ab5 = 1:  f9a1b4c8 lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  6fafe78d = 2:  9c1220ac lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v2j
  • Rebase
$ git rd
1:  f9a1b4c8 = 1:  0a0ff594 lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  9c1220ac = 2:  5beae545 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v2k
  • Rebase
$ git rd
1:  0a0ff594 = 1:  35a0dea5 lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  5beae545 = 2:  c6296395 lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
v2l
  • Rebase
$ git rd
1:  35a0dea5 = 1:  eaf7d6ab lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
2:  c6296395 = 2:  b7a93a7d lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()

@alejandro-colomar alejandro-colomar force-pushed the fmkomstemp branch 3 times, most recently from 3659215 to 6b28ca7 Compare December 4, 2024 13:24
@alejandro-colomar alejandro-colomar marked this pull request as ready for review December 4, 2024 13:31
@alejandro-colomar alejandro-colomar mentioned this pull request Dec 4, 2024
Closed
@alejandro-colomar alejandro-colomar force-pushed the fmkomstemp branch 2 times, most recently from dae656e to f6224cb Compare December 6, 2024 12:12
@alejandro-colomar
Copy link
Collaborator Author

Queued after the release of 4.17.0.

@alejandro-colomar alejandro-colomar marked this pull request as draft December 6, 2024 12:15
@alejandro-colomar alejandro-colomar marked this pull request as ready for review December 22, 2024 12:03
@alejandro-colomar alejandro-colomar added the Simpler A good issue for a new beginner label Dec 22, 2024
@alejandro-colomar alejandro-colomar force-pushed the fmkomstemp branch 2 times, most recently from b9f41b8 to e3c7ea4 Compare January 24, 2025 15:25
@alejandro-colomar alejandro-colomar force-pushed the fmkomstemp branch 4 times, most recently from 84ce312 to c76299c Compare February 16, 2025 22:57
@alejandro-colomar alejandro-colomar mentioned this pull request May 4, 2025
Closed
@alejandro-colomar alejandro-colomar force-pushed the fmkomstemp branch 4 times, most recently from 9c1220a to 5beae54 Compare May 30, 2025 22:30
@alejandro-colomar
lib/fs/mkstemp/, src/: fmkomstemp(): Move function to separate file
eaf7d6a 
And make it inline.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
@alejandro-colomar
lib/fs/mkstemp/: mkostemp(): Split API from fmkomstemp()
b7a93a7 
This reduces the complexity of fmkomstemp().

Signed-off-by: Alejandro Colomar <alx@kernel.org>
@hallyn hallyn merged commit 5fc6509 into shadow-maint:master Jun 3, 2025
10 checks passed
@alejandro-colomar alejandro-colomar deleted the fmkomstemp branch June 3, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallyn hallyn hallyn approved these changes

@ikerexxe ikerexxe Awaiting requested review from ikerexxe

Assignees
No one assigned
Labels
Simpler A good issue for a new beginner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alejandro-colomar @hallyn