Skip to content

Update TCPHandler.lastActivity upon successful send of bytes. #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2020
Merged

Update TCPHandler.lastActivity upon successful send of bytes. #2858

merged 1 commit into from
Apr 21, 2020

Conversation

notsure2
Copy link
Contributor

Fixes #2857

@celeron533 celeron533 requested review from chenshaoju and a user April 20, 2020 05:29
chenshaoju
chenshaoju approved these changes Apr 20, 2020
View reviewed changes
Copy link
Collaborator

@chenshaoju chenshaoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quick test is pass, Base appveyor version 4.1.10.8.
👍 Looks good to me, but someone else must approve.

@celeron533 celeron533 merged commit 6962cfe into shadowsocks:master Apr 21, 2020
@celeron533
Copy link
Contributor

Thank you for sending the pull request @notsure2 !
Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@chenshaoju chenshaoju chenshaoju approved these changes

@celeron533 celeron533 celeron533 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSH connection killed even when putty is set to send null packets due to timeout on TCPHandler being set on remote receive.
3 participants
@notsure2 @celeron533 @chenshaoju