Fix triton moe error caused by TopK refactor #8705
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @fzyzcjy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a specific error encountered in the Triton Mixture of Experts (MoE) implementation. The fix involves removing a problematic custom operation registration that was causing issues, likely due to a recent TopK refactor. The change aims to stabilize the MoE forward pass within the Triton kernels by eliminating the erroneous registration.
Highlights
- Triton MoE Error Fix: Removed the
direct_register_custom_opcall for thetriton_kernel_moe_forwardfunction intriton_kernels_moe.py. This registration was identified as the cause of an error following aTopKrefactor, and its removal resolves the issue.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a Triton MoE error by removing an obsolete custom operator registration. The change is straightforward and appears to be a good cleanup. I've pointed out some resulting dead code that could be removed in a follow-up to further improve maintainability.
|
this is just a very naive change to avoid runtime errors (since that register op is not used currently), and I am happy for whatever methods as long as there are no errors. e.g. @ch-wan mentions to keep aligned with another code branch and that looks pretty reasonable. |
Motivation
Modifications
Accuracy Test
Benchmark & Profiling
Checklist