[Doc] Polish sgl-kernel readme for cu126 build error #8704
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @FlamingoPg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've made a targeted update to the sgl-kernel README to address a critical build issue. My changes aim to inform users about a specific segmentation fault that can occur when compiling FlashAttention on Hopper GPUs with CUDA 12.6. This documentation addition will help users avoid this problem and ensure a smoother build process by highlighting the necessary compiler versions.
Highlights
- Documentation of Build Error: I've updated the
sgl-kernel/README.mdfile to include a new section titled "Compile sgl-kernel on cu126 problem". This section specifically warns users about a known issue. - Specific Error Description: I've documented that compiling FlashAttention with
sgl-kernelon Hopper architecture using CUDA 12.6 can lead to a "Segmentation fault (core dumped)" error. The exact error message snippet is provided for clarity. - Recommended Compiler Versions: I've reiterated the importance of using
nvccversion 12.6 andptxasversion 12.8 for successful FlashAttention compilation on Hopper (sm90) GPUs, placing this recommendation directly after the new error warning.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Motivation
Modifications
Accuracy Test
Benchmark & Profiling
Checklist