[bug] remove pdlb from minilb since its no longer available #8634
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the load balancing mechanism by removing the deprecated Rust-based load balancer (pdlb) and standardizing on the mini_lb implementation. This change reflects the integration of the Rust pdlb into sgl-router, making its standalone usage obsolete and simplifying the load balancer launch script.
Highlights
- Deprecation and Removal of Rust Load Balancer: I have removed all code paths and imports related to the
sgl_pdlb._rust.LoadBalancer(Rust-based load balancer) fromlaunch_lb.py, as it is no longer supported and has been merged intosgl-router. - CLI Argument Update: The help message for the
--rust-lbcommand-line argument inlaunch_lb.pyhas been updated to explicitly state that it is deprecated and will have no effect. - Load Balancer Standardization: The
launch_lb.pyscript now exclusively uses themini_lbimplementation, simplifying the codebase by removing the conditional logic that previously allowed switching between the Rust and mini load balancers.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated Rust load balancer (pdlb) and updates the argument help message. I've added comments suggesting simplification of the code by removing the now-unnecessary conditional logic and deprecated command-line argument.
| @@ -115,25 +117,8 @@ def main(): | |||
| args = parser.parse_args() | |||
| lb_args = LBArgs.from_cli_args(args) | |||
There was a problem hiding this comment.
Now that the Rust load balancer logic has been removed, the conditional check based on lb_args.rust_lb is no longer necessary. You can directly proceed with the mini_lb execution, simplifying the code flow.
prefill_configs = [PrefillConfig(url, port) for url, port in lb_args.prefill_infos]
run(prefill_configs, lb_args.decode_infos, lb_args.host, lb_args.port)
Motivation
rust pdlb is merged into sgl-router, this is no longer supported, removed
Modifications
remove the code and updated the argument help message
Accuracy Test
Benchmark & Profiling
Checklist