misc: Remove debug print to logger.info #8633
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @CatherineSue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've made a small but important change to improve logging consistency within the codebase. This pull request replaces a direct print statement with a logger.info call, ensuring that configuration details for sliding_window_size are integrated into the standard logging framework. This change helps to centralize log management and allows for better control over log output levels and destinations.
Highlights
- Logging Consistency: Replaced a
printstatement withlogger.infofor outputting thesliding_window_sizeconfiguration, aligning with standard logging practices.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly replaces a print statement with logger.info for logging during model loading. This change leverages the existing logging framework, which includes a RankZeroFilter to prevent log duplication across multiple tensor parallel ranks. The change is a clear improvement, adheres to good logging practices, and has been implemented correctly.
|
after: |
Motivation
Multiple debug lines from each TP.
Modifications
logger.infoAccuracy Test
Benchmark & Profiling
Checklist