[router] update router pypi version #8628
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the sglang-router's PyPI version to 0.1.7. This version bump reflects several significant recent changes to the router, including advancements in DP-aware routing, enhanced policy support for P and D nodes, a migration from Actix to Axum, refined timeout settings, improved logging with middleware and request IDs, and initial API key support. Additionally, an outdated release notes file for version 0.1.0 has been removed as part of this update.
Highlights
- PyPI Version Update: The
sglang-routerPyPI package version has been incremented from0.1.6to0.1.7. - File Removal: The
v0.1.0.mdfile, which contained release notes for an older version, has been removed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to bump the package version to 0.1.7 for a new release, which is justified by the significant changes listed in the description. However, the version update is incomplete. While sgl-router/pyproject.toml is updated, sgl-router/py_src/sglang_router/version.py remains at 0.1.4. This version inconsistency is a critical issue that must be fixed to ensure a clean release. The removal of the old v0.1.0.md release note seems like a reasonable cleanup.
105d98a to
0115001
Compare
Motivation
due to recent major changes
known limitation
Modifications
Accuracy Test
Benchmark & Profiling
Checklist