Tiny fix CI pytest error #8524
Tiny fix CI pytest error #8524
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @fzyzcjy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical CI failure by ensuring that the pytest testing framework is correctly included as a dependency for the project's test environment. This small but essential change will prevent future ModuleNotFoundError issues during automated testing, allowing CI pipelines to execute successfully.
Highlights
- CI Dependency Fix: Added
pytestto thetestdependency group inpyproject.tomlto resolve aModuleNotFoundErrorencountered during CI runs.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a CI failure by adding the missing pytest dependency to the test extras in pyproject.toml. My review includes one suggestion to maintain the alphabetical order of the dependency list for better code consistency and maintainability.
| @@ -108,6 +108,7 @@ test = [ | |||
| "pandas", | |||
| "peft", | |||
| "sentence_transformers", | |||
| "pytest", | |||
There was a problem hiding this comment.
Thanks for fixing the CI! For consistency and maintainability, could you please place pytest in its correct alphabetical position within the test dependency list? The list appears to be sorted alphabetically, and pytest should be placed after peft and before sentence_transformers.
Motivation
https://github.com/sgl-project/sglang/actions/runs/16592323202/job/46930773600?pr=8520
Modifications
Accuracy Test
Benchmark & Profiling
Checklist