Fix NCCL 2.27.3 not in docker image #7195
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @fzyzcjy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue where the NCCL 2.27.3 package was not being properly included in the Blackwell-specific Docker image. The fix involves adjusting the order of package installation commands within the Dockerfile to resolve the dependency or build issue.
Highlights
- Dockerfile Fix: Reordered installation steps in the
docker/Dockerfile.blackwellto ensure thenvidia-nccl-cu12package is installed correctly.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where NCCL 2.27.3 might not be correctly installed or active in the Dockerfile.blackwell image. The fix involves reordering the pip install commands to ensure nvidia-nccl-cu12==2.27.3 is installed after flashinfer_python==0.2.6.post1, using --force-reinstall to make its version authoritative.
While the change itself seems logical for resolving potential conflicts or overrides by flashinfer_python, the pull request description is currently minimal. It would significantly improve clarity and future maintainability if the description could be expanded to explain the specific reason for this reordering (e.g., does flashinfer_python install a conflicting NCCL version or a dependency that interferes?). This context is crucial for understanding the necessity of this particular installation order.
My feedback primarily focuses on enhancing maintainability by improving documentation, both in the PR description and potentially within the Dockerfile via comments. This aligns with general best practices for writing clear and understandable Dockerfiles. A specific suggestion for adding a clarifying comment to the Dockerfile has been provided.
| RUN pip3 install flashinfer_python==0.2.6.post1 --break-system-packages | ||
|
|
||
| RUN pip3 install nvidia-nccl-cu12==2.27.3 --force-reinstall --no-deps --break-system-packages |
There was a problem hiding this comment.
This reordering is likely to ensure nvidia-nccl-cu12==2.27.3 is the effective version. For long-term maintainability, consider adding a comment in the Dockerfile explaining why this specific order (installing nvidia-nccl-cu12 after flashinfer_python) is crucial. For instance:
# Install flashinfer first, as it might affect NCCL components.
RUN pip3 install flashinfer_python==0.2.6.post1 --break-system-packages
# Force-reinstall nvidia-nccl-cu12 to ensure the correct version (2.27.3) is present.
RUN pip3 install nvidia-nccl-cu12==2.27.3 --force-reinstall --no-deps --break-system-packagesThis context is valuable if not fully detailed in the PR description.
Motivation
@zhyncs says how to fix
Modifications
Checklist