Increase timeout in test/srt/test_disaggregation.py #7175
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @merrymercy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to enhance the reliability of the test_disaggregation.py test suite by extending the waiting period for a server to become ready. This change is intended to mitigate test failures caused by timeouts on systems where setup or startup might take longer than the previously configured limit.
Highlights
- Test Stability: Increased a timeout value in a test helper function to potentially improve test stability, especially in slower environments.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This PR increases the server readiness timeout for the TestDisaggregationMooncakeFailure test class from 60s to 300s. My review of this change includes:
- A request for a code comment to explain the necessity of this significantly longer timeout for this specific test scenario.
- A suggestion to define the new timeout value (300) as a named constant (e.g.,
_FAILURE_SIMULATION_SERVER_READY_TIMEOUT) to improve readability. This suggestion aligns with PEP 8 conventions for constants (uppercase with underscores).
Additionally, during the review of the surrounding code for context, I observed that the wait_server_ready method is duplicated in several test classes within this file (TestDisaggregationAccuracy, TestDisaggregationMooncakeFailure, TestDisaggregationMooncakeSpec). Consolidating this into a common utility function or a base class method could enhance maintainability. Furthermore, in the TestDisaggregationMooncakeSpec class, this method appears to be defined twice (at lines 391 and 445), with the latter definition overwriting the former; this redundancy should likely be addressed in a follow-up.
No description provided.