chore: bump v0.1.8.post1 #7152
chore: bump v0.1.8.post1 #7152
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @zhyncs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is a chore task to bump the version of the sgl-kernel package to 0.1.8.post1. It involves updating version declarations in various build configuration files, the package's internal version file, and the Dockerfile that consumes the package.
Highlights
- Version Bump: I've updated the
sgl-kernelpackage version from0.1.8to0.1.8.post1. - Configuration Files: The version string has been updated in the main, CPU, and ROCm
pyproject.tomlfiles. - Internal Version: The
__version__string within thesgl_kernel.versionmodule has been updated. - Dockerfile: The
Dockerfile.blackwellnow points to the newly releasedv0.1.8.post1wheel forsgl_kernel.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly bumps the version of sgl-kernel to 0.1.8.post1 across the relevant pyproject.toml files, python/sgl_kernel/version.py, and the docker/Dockerfile.blackwell. The changes appear consistent and accurate for a version bump.
To further improve the release process and maintainability, please consider the following:
-
Pull Request Description: The PR description is currently using the default template. For better traceability and context, especially for releases, it would be beneficial to fill in the "Motivation" and "Modifications" sections. For instance, briefly explaining the reason for this
post1release (e.g., critical bug fix, minor update) would be helpful. -
Changelog/Release Notes: If
v0.1.8.post1includes any user-facing changes, such as bug fixes or minor features compared tov0.1.8, it's important to update the project's changelog or create release notes. This ensures users are aware of what the new version offers. The checklist item[ ] Update documentation / docstrings / example tutorials as neededshould cover this. -
Release Guide in README: The developer guide in
sgl-kernel/README.md(section "Release new version") currently mentions updatingpyproject.tomlandversion.py. To make this guide more comprehensive, it could be updated to include all files that typically require version changes during a release. Based on this PR, this would include:sgl-kernel/pyproject_cpu.tomlsgl-kernel/pyproject_rocm.toml- And potentially a note about checking Dockerfiles (like
docker/Dockerfile.blackwell) or other build/CI scripts that might pin to specific release artifact URLs.
This would help ensure consistency in future releases.
|
verified locally |
Motivation
Modifications
Checklist