Fix positional argument #7093
Fix positional argument #7093
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @liquanfeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates two call sites in benchmark and test scripts to align with a likely change in a function signature, adding a boolean argument. This change ensures that the benchmark and test code correctly invoke the updated function, potentially enabling a specific processing mode like per-token dynamic behavior.
Highlights
- Benchmark Update: Updated the
benchmark_ep_pre_reorder_triton.pyscript to pass a new positional argument (True) to therun_kernelfunction call. - Test Update: Updated the
test_block_fp8_ep.pyscript to pass a new keyword argument (use_per_token_if_dynamic=True) to theep_moefunction call.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
benchmark/kernels/fused_moe_triton/benchmark_ep_pre_reorder_triton.py
Outdated
Show resolved
Hide resolved
…iton.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Motivation
Fix positional argument
Modifications
add positional argument
Checklist