Add gfx950 support for sgl-kernel. #7092
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @sogalin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the sgl-kernel build process to support the gfx950 AMD GPU architecture. It achieves this by dynamically detecting the target GPU architecture at build time and passing the correct flag to the compiler, rather than relying on a hardcoded value.
Highlights
- GPU Architecture Detection: The build script (
setup_rocm.py) now dynamically detects the AMD GPU architecture (gcnArchName) usingtorch.cuda.get_device_propertiesinstead of hardcodinggfx942. - gfx950 Support: Adds explicit support for the
gfx950architecture by allowing it as a valid target during the build process. - Architecture Validation: Includes a check to ensure the detected architecture is either
gfx942orgfx950, exiting the build if an unsupported architecture is found.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request adds support for the gfx950 GPU architecture to the sgl-kernel setup. It modifies the setup_rocm.py file to dynamically determine the AMD GPU architecture and set the appropriate compilation flags. The code also includes a check to ensure that the detected GPU architecture is supported.
|
@sogalin Lint |
|
@sogalin @hubertlu-tw @saienduri @kkHuang-amd |
Motivation
Add sgl-kernel to support gfx950.
Modifications
To get amdgpu-target from gcnArchName.
Checklist