-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Clean up docs for server args and sampling parameters (generated by grok) #7076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @merrymercy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on cleaning up and expanding the documentation for the server's command-line arguments and the parameters used in the /generate
endpoint and sampling. The changes aim to provide a more comprehensive and organized reference for users configuring the server and making API requests, including details on newly supported features and optimizations.
Highlights
- Documentation Updates: Significant updates and reorganization of the documentation for server command-line arguments (
server_arguments.md
) and/generate
endpoint/sampling parameters (sampling_params.md
). - New Parameters Documented: Added documentation for new parameters in the
/generate
endpoint (e.g.,input_embeds
,image_data
,audio_data
,rid
, logprob options) and sampling parameters (structural_tag
). - Server Argument Standardization and Expansion: Server arguments in the documentation are standardized to use the
--
prefix and many new arguments related to quantization, multimodal features, parallelism (pipeline, expert), logging, API features, optimization, and prefill/decode disaggregation are added. - Documentation Structure Refinement: The
server_arguments.md
file is restructured into more granular sections for better clarity (e.g., Model, Memory, Logging, API, Parallelism types, Optimization, Disaggregation).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request cleans up documentation for server arguments and sampling parameters. The documentation changes improve clarity and organization. The code changes update help texts and reorder argument definitions.
Grok is cool |
No description provided.