Revert "Add sanity checks when a test file is not added to CI (#6947)" #7063
Conversation
This reverts commit fe55947.
There was a problem hiding this comment.
Summary of Changes
Hello @zhyncs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've summarized this pull request which aims to undo a previous change that implemented a check to ensure all test files were accounted for in the test suite configuration. The revert removes this validation logic and the associated list of files that were previously marked as excluded from CI.
Highlights
- Revert Sanity Check: This pull request reverts the changes introduced in PR #6947, which added a sanity check to
test/srt/run_suite.pyto verify that all test files were either included in a test suite or explicitly listed in a__not_in_ci__section. - Remove Excluded File List: As part of the revert, the large
__not_in_ci__dictionary entry that listed numerous test files intended to be excluded from the CI run is removed fromtest/srt/run_suite.py.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request reverts commit fe55947a, which had introduced sanity checks to ensure all test files are accounted for in the CI configuration.
Motivation for Revert:
The PR description currently lacks details on why this revert is necessary. Could you please update the "Motivation" section to explain the reasons? Understanding the context (e.g., if the original check was causing issues such as performance degradation, maintenance overhead for the exclusion list, or if an alternative mechanism is now in place) is crucial for a comprehensive review.
Impact of Reverting:
By removing the _sanity_check_suites function and the associated __not_in_ci__ list, an automated safeguard against unintentionally omitting test files from CI is being eliminated. This change could potentially lead to gaps in test coverage if new test files are added to the repository but not correctly configured to run in CI. It would be valuable to understand how this potential risk will be mitigated going forward.
This reverts commit fe55947.
Motivation
Modifications
Checklist