Fix test_lora.py CI #7061
Fix test_lora.py CI #7061
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @Fridge003, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to fix CI instability by commenting out a test prompt in test_lora.py that has been identified as a source of inconsistent results. The prompt is intended to be re-added once the underlying issue causing the inconsistency is resolved.
Highlights
- CI Stability: Temporarily removed a specific test prompt in
test_lora.pythat was causing inconsistent output and failing CI runs.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses CI instability by temporarily commenting out a problematic test prompt in test_lora.py. A TODO comment is added to indicate that the prompt should be re-added after the underlying bug is fixed. This is a pragmatic approach to unblock CI.
Motivation
A prompt in
test_lora.pyoften causes inconsistency in output, which breaks CI.This PR remove this prompt temporarily, it should be added back after its bug is fixed.
Modifications
Checklist