Tiny fix cutlass_mla_get_workspace_size stub incorrect signature #7057
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @fzyzcjy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor issue by fixing the signature of a stub function. The cutlass_mla_get_workspace_size function, which serves as a placeholder when a specific CUDA version is not available, had an incorrect parameter list. This change updates the stub's signature to match the expected one, ensuring correctness even in unsupported environments and preventing potential compilation issues.
Highlights
- Stub Function Signature Fix: Corrected the function signature for the
cutlass_mla_get_workspace_sizestub implementation used when CUDA version is less than 12.4.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This PR updates the signature of the cutlass_mla_get_workspace_size stub function to include the num_kv_splits parameter, aligning it with the actual implementation. I've included a suggestion to mark unused parameters in the stub for better maintainability.
| @@ -37,7 +37,7 @@ void cutlass_mla_decode( | |||
| torch::Tensor const& workspace) { | |||
| TORCH_CHECK(false, "CUDA version must be >= 12.4 for cutlass_mla_decode"); | |||
| } | |||
| int64_t cutlass_mla_get_workspace_size(int64_t max_seq_len, int64_t num_batches, int64_t sm_count) { | |||
| int64_t cutlass_mla_get_workspace_size(int64_t max_seq_len, int64_t num_batches, int64_t sm_count, int64_t num_kv_splits) { | |||
There was a problem hiding this comment.
Consider commenting out the parameter names in this stub function to avoid compiler warnings about unused parameters and improve code clarity.
int64_t cutlass_mla_get_workspace_size(int64_t /*max_seq_len*/, int64_t /*num_batches*/, int64_t /*sm_count*/, int64_t /*num_kv_splits*/) {
|
My fault orz. |
Motivation
Modifications
Checklist