Disable all two stream overlap on amd #6475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
887151f to
4bae19b
Compare
| @@ -392,7 +398,7 @@ def set_kv_buffer( | |||
| cache_k = cache_k.view(self.store_dtype) | |||
| cache_v = cache_v.view(self.store_dtype) | |||
|
|
|||
| if self.capture_mode and cache_k.shape[0] < 4: | |||
| if self.capture_mode and self.alt_stream is not None: | |||
There was a problem hiding this comment.
Is it expected to remove the batch size check and do the overlap for all batch sizes ? in that case we should remove the comment on the next line
Layssy
pushed a commit
to Layssy/sglang-iaas
that referenced
this pull request
Jun 9, 2025
xwu-intel
pushed a commit
to xwu-intel/sglang
that referenced
this pull request
Jun 17, 2025
Yuechguo
pushed a commit
to Yuechguo/sglang
that referenced
this pull request
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.