Skip to content

Conversation

slin1237
Copy link
Collaborator

@slin1237 slin1237 commented Apr 28, 2025

Motivation

  1. When building the project on macOS, we encountered linking errors with PyO3 - the linker couldn't find Python symbols like _PyBaseObject_Type and others
  2. We had redundant logging dependencies (log and tracing)

Modifications

  1. Added .cargo/config.toml with platform-specific configurations (default to Linux support, added Mac Arm and X86 chip, no windows support)
  2. Removed unnecessary dependencies in Cargo.toml, including env_logger, log, and chrono
  3. Migrated from log to tracing in router.rs

Checklist

@slin1237
Copy link
Collaborator Author

compiled in both linux and mac
Linux:
Screenshot 2025-04-28 at 12 05 12 PM
Mac
Screenshot 2025-04-28 at 12 04 45 PM

@slin1237 slin1237 requested review from merrymercy and zhyncs April 28, 2025 19:26
@slin1237 slin1237 force-pushed the slin/logging-update branch from 43f8926 to 97d2222 Compare April 29, 2025 17:37
Copy link
Collaborator

@ByronHsu ByronHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing so many improvements!

@slin1237 slin1237 merged commit 771669c into main Apr 29, 2025
4 checks passed
@slin1237 slin1237 deleted the slin/logging-update branch April 29, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants