Skip to content

Fix a regression introduced by overlapping KV cache writing #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

Fix a regression introduced by overlapping KV cache writing #4375

merged 2 commits into from
Mar 13, 2025

Conversation

merrymercy
Copy link
Contributor

@merrymercy merrymercy commented Mar 13, 2025 •
edited
Loading

Fix a perf regression on throughput introdcued by #4356

@merrymercy merrymercy changed the title Try page size overhead Fix a regression introduced by overlapping Mar 13, 2025
@merrymercy merrymercy changed the title Fix a regression introduced by overlapping Fix a regression introduced by overlapping KV cache writing Mar 13, 2025
@zhyncs zhyncs merged commit 4fea040 into main Mar 13, 2025
1 of 5 checks passed
@zhyncs zhyncs deleted the pr-page-overhead branch March 13, 2025 10:49
hebiao064 pushed a commit to hebiao064/sglang that referenced this pull request Mar 13, 2025
@merrymercy @hebiao064
Fix a regression introduced by overlapping KV cache writing (sgl-proj…
8e14efc 
…ect#4375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhyncs zhyncs zhyncs approved these changes

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merrymercy @zhyncs