Skip to content

[Eagle] Remove the greedy branch and some redundant code #4363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 16, 2025
Merged

[Eagle] Remove the greedy branch and some redundant code #4363

merged 6 commits into from
Mar 16, 2025

Conversation

Ying1123
Copy link
Member

@Ying1123 Ying1123 commented Mar 13, 2025 •
edited by merrymercy
Loading

  • Use faster kernel for temp=0
  • Support cuda graph padding
  • Simplify redundant python code

llama 2 7b: 390 token/s -> 400 token/s with this PR

Co-authored-by: Sehoon Kim <sehoon@x.ai>

@Ying1123 Ying1123 mentioned this pull request Mar 13, 2025
Merged
@Ying1123 Ying1123 force-pushed the ying-eagle branch 2 times, most recently from 8b8df4f to acaa267 Compare March 14, 2025 10:36
@merrymercy merrymercy merged commit 1b85929 into main Mar 16, 2025
4 of 22 checks passed
@merrymercy merrymercy deleted the ying-eagle branch March 16, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@rkooo567 rkooo567 Awaiting requested review from rkooo567 rkooo567 is a code owner

@kssteven418 kssteven418 Awaiting requested review from kssteven418 kssteven418 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@HandH1998 HandH1998 Awaiting requested review from HandH1998 HandH1998 is a code owner

@BBuf BBuf Awaiting requested review from BBuf BBuf is a code owner

@yizhang2077 yizhang2077 Awaiting requested review from yizhang2077 yizhang2077 is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@ByronHsu ByronHsu Awaiting requested review from ByronHsu

1 more reviewer

@muniu-brian muniu-brian muniu-brian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ying1123 @muniu-brian @merrymercy