Avoid requesting HF Hub metadata when local cache exists #4875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Looks good! But it seems failed on AMD docker. Maybe we can only do it for NV? |
|
@merrymercy Hi I replied in the slack channel, shortly speaking, it seems not easy to find a way to differenciate "there is only configs locally" (the case that directly make AMD test fail) vs "there are some but not all weight files locally" (e.g. when a previous CI run downloads half thing and then gets cancelled or network error) vs "there are all files locally" (the case that we can safely not query hf server). |
|
After discussion, we will close this PR and choose the HF_HUB_OFFLINE=1 way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Checklist