[feat] fix some numel and refactor torch binding #4867
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR do three things
from: m.def("all_reduce(int fa, Tensor inp, Tensor! out) -> ()");
m.impl("all_reduce", torch::kCUDA, &all_reduce);to: m.def("all_reduce", all_reduce);simplify the kernel define logic
|
zhyncs
reviewed
Mar 28, 2025
| @@ -4,9 +4,9 @@ | |||
| [submodule "sgl-kernel/3rdparty/cccl"] | |||
There was a problem hiding this comment.
We no longer need to update git modules because we have switched to CMake.
zhyncs
reviewed
Mar 28, 2025
| GIT_REPOSITORY https://github.com/flashinfer-ai/flashinfer | ||
| GIT_TAG 79fd1ae90d9b8098ca70dec6071da96f3f6da7b9 | ||
| GIT_REPOSITORY https://github.com/sgl-project/flashinfer | ||
| GIT_TAG 2b9f16eb79bd344e31725e8d7a92fe7fe980ffdf |
zhyncs
reviewed
Mar 28, 2025
| @@ -22,181 +22,67 @@ TORCH_LIBRARY_EXPAND(sgl_kernel, m) { | |||
| /* | |||
| * From csrc/allreduce | |||
| */ | |||
| m.def( | |||
There was a problem hiding this comment.
revert this first in #4871 to unblock the new release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix some numel and refactor torch binding
Modifications
Checklist