[ROCm] fix dtype #4510
Merged
[ROCm] fix dtype #4510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HaiShaw |
|
Thanks a lot! |
hebiao064
reviewed
Mar 17, 2025
| @@ -108,10 +108,15 @@ def process_weights_after_loading(self, layer: torch.nn.Module) -> None: | |||
| layer.weight, layer.weight.shape[-1] | |||
| ) | |||
| weight_scale = weight_scale.t().contiguous() | |||
| if _is_hip: | |||
There was a problem hiding this comment.
does AMD also supported Cutlass? I thought it's not...
There was a problem hiding this comment.
CK_tile (cutlass in AMD I personally believe) is currently recommended to program complex kernel fusion.
It contains tile window - ddr window transformation, pipeliner and partitioner. Very useful. You can check it out. D
And in the recently ASM kernels, they added many asm level optimizations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix fp8 dtype problem introduced in #4485
Modifications
Checklist