Nicer standalone engine inferface #4480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
requested changes
Mar 17, 2025
| @@ -246,7 +246,16 @@ def encode( | |||
|
|
|||
| def shutdown(self): | |||
| """Shutdown the engine""" | |||
| kill_process_tree(os.getpid(), include_parent=False) | |||
There was a problem hiding this comment.
include_parent is already False by default, so it won't kill the parent process.
You changed it to True by default, and it failed many CI test. Is this still necessary?
There was a problem hiding this comment.
I see. I didn't notice the change. let me check
This reverts commit 92b7891.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Two improvement
Modifications
Checklist